-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add comment to PR after benchmark runs #781
Conversation
Signed-off-by: Thomas Jungblut <[email protected]>
it seems I can't request the WRITE for issues/pullrequests from our workflow permissions:
even when I request "write-all". is there a repo/org setting that we need to tweak for this? |
It sounds to me like it's a similar issue from the discussion from this comment https://github.com/etcd-io/website/pull/845#issuecomment-2168851307https://github.com/etcd-io/website/pull/845#issuecomment-2168851307. James suggested setting the org-level permissions could be a dead end in that case. In that case, maybe the only option would be to do it through a prow plugin, but the investment to build it is bigger. |
@jmhbnz can we raise this again with the right people? It seems a bit ridiculous to not have this set on an org level... |
Raised discussion with k8s |
I wonder if we're missing something, as it seems like our Otherwise, based on the response from |
The existing behavior is already good enough: the benchmark workflow will fail if there is any unexpected performance reduce. We don't have to necessarily spend too much effort to automatically add a comment. |
let's close, we can dig this up with Prow once more |
No description provided.